Fix AbciQuery to support error response. #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
abci_query_error_response
branch
from
40ab674
to
bd03874
Compare
liamsi
reviewed
Nov 28, 2019
|
|
||
| /// Proof (if requested) | ||
| pub proof: Option<Proof>, | ||
|
|
||
| /// Block height | ||
| pub height: block::Height, | ||
| #[serde(default, deserialize_with = "serializers::parse_height_option")] | ||
| pub height: Option<block::Height>, |
There was a problem hiding this comment.
So these are only optional now as they are None in case of an error response.
liamsi
reviewed
Nov 28, 2019
| #[test] | ||
| fn parse_query_responses() { | ||
| let error_rsp = r#"{"response": {"code": 1, "log": "account lookup failed: account not found", "info": "", "index": "0", "key": null, "value": null, "proof": null, "height": "0", "codespace": ""}}"#; | ||
| let success_rsp = r#"{"response": {"value": "some value"}}"#; |
There was a problem hiding this comment.
Doesn't a successful response also include code etc and not only value? Let me double check.
There was a problem hiding this comment.
It seems it depends solely on the abci app's implementation, and since it's protobuf, every field is optional.
There was a problem hiding this comment.
It might be good to update our fixtures in the rpc to contain both JSON files, the happy path and the error case:
https://docs.tendermint.com/master/rpc/#/ABCI/abci_query
5 tasks
Closed
|
It's fixed in current master, closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
{"response": {"code": 1, "log": "account lookup failed: account not found", "info": "", "index": "0", "key": null, "value": null, "proof": null, "height ": "0", "codespace": ""}}