-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc-probe fixes and kvstore-fixtures and tests #758
Conversation
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
========================================
+ Coverage 43.1% 48.8% +5.7%
========================================
Files 204 197 -7
Lines 13620 13080 -540
Branches 3571 3226 -345
========================================
+ Hits 5874 6391 +517
+ Misses 7369 6323 -1046
+ Partials 377 366 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Closes #756 .
Part of #723 .
Important: all the JSON files in the change are auto-generated by
rpc-probe
. Do not review them in detail. (Here's a link where json files are filtered out.)Moved the
rpc-probe
folder intotools/rpc-probe
.Removed the
run-with-docker.sh
script and implemented docker management usingcargo-make
intools/rpc-probe/Makefile.toml
.Changed
rpc-probe
to dump its results intorpc/tests/kvstore_fixtures
by default.Implemented
rpc/tests/kvstore_fixtures.rs
tests that parse the rpc-probe results into Tendermint structs and make assertions against them.rpc-probe
now generates requests withnull
input instead of{}
where there is no parameter for the request. (Deserialization is implemented fornull
s.)abci::transaction:Hash
now has thePartialEq
derive for easier testing.AbciQuery::prove
now has default serialization. (That was a small bug.)Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Updated CHANGELOG.md