Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on master #83

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix build on master #83

merged 1 commit into from
Dec 10, 2019
+51 −54

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Dec 10, 2019

list d25519-dalek dep, adapt to renaming (simple_merkle hickup), and fmt:

  • Fix abci_query RPC endpoint #77 introduced an fmt issue
  • Light client: trait impls #36 was not up-to date regarding changes which were merged to master (renaming
    of simple_merkle)
  • new upstream release of made build of master fail (solution: explicitly add it
    ed25519-dalek (1.0.0-pre.3) with rand feature fixes that

@liamsi
Fix master: ed25519-dalek dep, adapt to renaming (simple_merkle hicku…
6579c97 
…p), and fmt:

 - #77 introduced an fmt issue
 - #36 was not up-to date regarding changes which were merged to master (renaming
   of simple_merkle)
 - new upstream release of made build of master fail (solution: explicitly add it
 ed25519-dalek (1.0.0-pre.3) with rand feature fixes that
@liamsi liamsi marked this pull request as ready for review December 10, 2019 19:29
ebuchman
ebuchman approved these changes Dec 10, 2019
View reviewed changes
tendermint/src/block/header.rs
byteslices.push(proposer_address_enc.as_slice());

Hash::Sha256(simple_hash_from_byte_slices(byteslices.as_slice()))
let mut byteslices: Vec<Vec<u8>> = vec![];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this variable name at some point :)

@ebuchman ebuchman merged commit 9415981 into master Dec 10, 2019
@ebuchman ebuchman deleted the fix_master branch December 10, 2019 19:34
tarcieri pushed a commit to tendermint/signatory that referenced this pull request Dec 11, 2019
@tony-iqlusion
Cargo.toml(s): lock directly to all prerelease crates
39dcdfe 
These crates are effectively semver incompatible from each other and may
bring unexpected changes:

informalsystems/tendermint-rs#83

This ensures that all crates are locked to a known working prerelease
which they were tested with.
@tarcieri tarcieri mentioned this pull request Dec 11, 2019
Merged
@liamsi liamsi mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman approved these changes

@tarcieri tarcieri Awaiting requested review from tarcieri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamsi @ebuchman