Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add equality/ordering/hash trait bounds to RPC URL types #921

Merged
merged 4 commits into from
Jun 27, 2021
Merged

Add equality/ordering/hash trait bounds to RPC URL types #921

merged 4 commits into from
Jun 27, 2021

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Jun 25, 2021 •
edited
Loading

Closes #919

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@thanethomson
Implement traits for rpc::Url
34d4eb0 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Implement traits for transport URL types
cac9fef 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Implement missing conversions back to rpc::Url type
7b5dae2 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Add changelog entry
6747796 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review June 25, 2021 20:05
@thanethomson thanethomson requested a review from romac June 26, 2021 13:01
romac
romac approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@romac romac merged commit 7b84781 into master Jun 27, 2021
@romac romac deleted the thane/919-rpc-url-bounds branch June 27, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PartialEq, Eq, PartialOrd, Ord, Hash bounds to tendermint_rpc::Url
2 participants
@thanethomson @romac