Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate RPC domain types #922

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

thanethomson
Copy link
Contributor

Closes #918

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

Codecov Report

Merging #922 (5d3a24c) into master (c8b97aa) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 5d3a24c differs from pull request most recent head 5783991. Consider uploading reports for the commit 5783991 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master    #922     +/-   ##
========================================
- Coverage    70.7%   70.6%   -0.1%     
========================================
  Files         203     203             
  Lines       16230   16241     +11     
========================================
+ Hits        11475   11477      +2     
- Misses       4755    4764      +9     
Impacted Files Coverage Δ
rpc/src/event.rs 11.4% <ø> (-4.0%) ⬇️
rpc/tests/kvstore_fixtures.rs 95.5% <100.0%> (+<0.1%) ⬆️
tendermint/src/abci/responses.rs 69.5% <100.0%> (ø)
rpc/src/endpoint/blockchain.rs 40.0% <0.0%> (-60.0%) ⬇️
tendermint/src/moniker.rs 70.0% <0.0%> (-30.0%) ⬇️
rpc/src/endpoint/health.rs 20.0% <0.0%> (-30.0%) ⬇️
rpc/src/endpoint/abci_query.rs 17.6% <0.0%> (-3.8%) ⬇️
tendermint/src/config.rs 64.5% <0.0%> (-1.3%) ⬇️
light-client/src/types.rs 30.3% <0.0%> (-0.6%) ⬇️
rpc/src/method.rs 28.8% <0.0%> (-0.5%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b97aa...5783991. Read the comment docs.

@thanethomson thanethomson requested a review from ancazamfir June 28, 2021 11:36
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

🐳 🤘 🌱 🌛

@thanethomson thanethomson merged commit a748118 into master Jul 12, 2021
@thanethomson thanethomson deleted the thane/918-dedup-domaintypes branch July 12, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate domain types
3 participants