Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: replace prost-amino with prost #979

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Commits on Sep 16, 2021

  1. p2p: replace prost-amino with prost

    The only message that `prost-amino` was still used for was
    `AuthSigMessage`, and the only way an amino-encoded version of that
    message differs from a proto is the amino type prefix on the `pub_key`
    field, i.e. `tendermint/PubKeyEd25519`.
    
    This commit adds a test vector for a serialized amino message, and then
    changes `AuthSigMessage` to use `prost-derive`:
    
    - An `AuthSigMessage::new` function takes care of adding the Amino
      prefix to the public key
    - A `TryFrom` impl for `proto::p2p::AuthSigMessage` takes care of
      verifying and removing it
    
    With that, `prost-amino` is no longer necessary and this commit
    therefore removes the last dependency on it.
    tony-iqlusion committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    beed538 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. p2p: restore test = false, remove Amino compat test

    It seems tests are now placed in a `test` crate, however this is a
    private API that cannot be called from a separate crate.
    
    Hopefully all Amino support can be removed soon, so now that
    compatibility has been achieved it shouldn't really matter.
    tony-iqlusion committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5ed14d2 View commit details
    Browse the repository at this point in the history
  2. p2p: fix clippy nits

    tony-iqlusion committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    d0d0c5b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90e3ff0 View commit details
    Browse the repository at this point in the history