Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-417 | Fix dashboard widgets and refactor size change handler #708

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Dec 3, 2024

See OH2-417

Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem seems to have been solved, but the pie charts are now oval instead of circular.

Screenshot 2024-12-06 at 09-26-43 Open Hospital

@SteveGT96 SteveGT96 requested a review from SilverD3 December 6, 2024 15:18
@mwithi
Copy link
Member

mwithi commented Dec 7, 2024

It seems that the aspect-ratio is not maitained:

chrome-capture-2024-12-7

@SteveGT96
Copy link
Contributor Author

It seems that the aspect-ratio is not maitained:

chrome-capture-2024-12-7 chrome-capture-2024-12-7
Hello @mwithi ! Just put an update !

@mwithi
Copy link
Member

mwithi commented Dec 9, 2024

Hello @mwithi ! Just put an update !

with sizes bigger than default one is ok, for smaller sizes it is still out of ratio:

image

@SilverD3
Copy link
Contributor

SilverD3 commented Dec 9, 2024

Screenshot 2024-12-09 at 10-44-04 Open Hospital

'Min' and 'max' sizes of widgets have changed and they're still looking flatten.
Furthermore, now they're not filling all the available space in their container

@mwithi
Copy link
Member

mwithi commented Dec 17, 2024

I guess you already tested it, so maybe there is something that depends by the user screen.

After many tries, I found that any size is good but the ones below the default width (default height seems also the minimum):

chrome-capture-2024-12-17

@SteveGT96
Copy link
Contributor Author

I guess you already tested it, so maybe there is something that depends by the user screen.

After many tries, I found that any size is good but the ones below the default width (default height seems also the minimum):

chrome-capture-2024-12-17 chrome-capture-2024-12-17

Hi @mwithi ! What do you suggest ?

Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The chart animation is a little bit slow, though. But it's too bad

@mwithi
Copy link
Member

mwithi commented Jan 8, 2025

LGTM! The chart animation is a little bit slow, though. But it's too bad

I guess you meant "it's NOT too bad" 😄. LGTM!
(but we have to do something for the slow animation...)

@mwithi mwithi merged commit c244480 into informatici:develop Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants