Generalize reference targets for Table define utility methods #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… references - add Table._expand_references() utility method - refactor Table.define_association implementation - generalize Table.define column_defs argument - generalize Table.define_vocabulary column_defs argument - generalize Table.define_asset column_defs argument - generalize Table.define_page column_defs argument - add Table.create_reference(target) method The generalized methods all accept the target reference inputs as understood by define_association when mixed into their column_defs argument list. As with association metadata, these target references are converted into corresponding Column.define() and ForeignKey.define() results to add to the table definition. The Table.create_reference(target) method allows incremental expansion of one existing table with column(s) and a foreign key referencing the designated target.
For the refactored internal use, we expect a mutable list instance. If a non-list is supplied, copy it into a list so the utility works reliably.
When provide_system=True AND provide_system_fkeys=True, it will add the foreign keys from RCB and RMB to the ERMrest_Client table
…le define methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a Table.define_association utility method was added, including a concept of reference targets to simplify the construction of columns and foreign key constraints. This PR generalizes the reference target concept so that other Table definition utilities can also supply reference targets instead of basic column and foreign key definitions.