Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark.mode.include=no not working #152

Closed
lakokkonen opened this issue Dec 5, 2023 · 1 comment · Fixed by #153
Closed

dark.mode.include=no not working #152

lakokkonen opened this issue Dec 5, 2023 · 1 comment · Fixed by #153
Labels
bug
Milestone
5.3.4

Comments

@lakokkonen
Copy link
Contributor

Setting the dark.mode.include parameter to no still creates the link to the .js file and thus enables dark mode.

In the insertParameters.xml file the parameter is called BOOTSTRAP_DARK_MODE_INCLUDE, but in the html5-bootstrap.xsl it's called BOOTSTRAP_DARK_MODE_TOGGLER_INCLUDE.

Naming them similarly fixes the issue.
@jason-fox jason-fox mentioned this issue Dec 5, 2023
Merged
@infotexture infotexture added the bug label Dec 9, 2023
@infotexture
Copy link
Owner

@lakokkonen Good catch, thanks for reporting. 🙏

infotexture pushed a commit that referenced this issue Dec 9, 2023
@jason-fox
Rename BOOTSTRAP_DARK_MODE_INCLUDE parameter (#153)
b962be4 
Fixes #152.
@infotexture infotexture added this to the 5.3.4 milestone Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.3.4
Development

Successfully merging a pull request may close this issue.

Rename BOOTSTRAP_DARK_MODE_INCLUDE parameter jason-fox/dita-bootstrap
2 participants
@infotexture @lakokkonen