Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infrad components style fix #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

TYWZLucifer
Copy link

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#4.9.0
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#4.9.0

@github-actions
Copy link

Prepare preview

components/page-header/index.tsx Show resolved Hide resolved
components/page-header/index.tsx Outdated Show resolved Hide resolved
components/page-header/style/index.less Show resolved Hide resolved
components/card/Card.tsx Outdated Show resolved Hide resolved
components/descriptions/index.tsx Outdated Show resolved Hide resolved
components/page-header/index.tsx Outdated Show resolved Hide resolved
components/page-header/style/index.less Outdated Show resolved Hide resolved
@@ -45,6 +45,7 @@ interface StepsType extends React.FC<StepsProps> {

const Steps: StepsType = props => {
const {
type,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是新增一个props吗

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是新增属性,原本就有。只是原有样式没有用到。 我们的设计稿里在这个组件处于导航模式的时候每个step有16的下边距,所以需要判断

components/table/style/index.less Outdated Show resolved Hide resolved
components/page-header/index.tsx Show resolved Hide resolved
@@ -137,6 +138,7 @@ function InternalTable<RecordType extends object = any>(
sortDirections,
locale,
showSorterTooltip = true,
outline = true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是新增的属性吗,新增属性的话,文档中需要更新

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants