Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] BotKube is crashing when invalid resource format provided #333

Closed
PrasadG193 opened this issue Sep 7, 2020 · 0 comments · Fixed by #335
Closed

[BUG] BotKube is crashing when invalid resource format provided #333

PrasadG193 opened this issue Sep 7, 2020 · 0 comments · Fixed by #335
Labels
bug Something isn't working release-blocker Upcoming release is blocked by this issue

Comments

@PrasadG193
Copy link
Collaborator

PrasadG193 commented Sep 7, 2020 •
edited
Loading

Describe the bug

BotKube with latest build crashes in name in resource config is not in G/V/R format

To Reproduce
Deploy BotKube from develop branch with the latest image. Use the following resource configuration

config:
  ## Resources you want to watch
  resources:
    - name: pod
      namespaces:
        include:
          - all
        ignore:
          -

Additional Context
Crash logs: https://gist.github.com/PrasadG193/4da70950d10e5a75815d9bfde586e4a2
@PrasadG193 PrasadG193 added bug Something isn't working release-blocker Upcoming release is blocked by this issue labels Sep 7, 2020
@PrasadG193 PrasadG193 changed the title [BUG] BotKube is crashing is invalid resource format is provided [BUG] BotKube is crashing when invalid resource format provided Sep 7, 2020
@rahulchheda rahulchheda mentioned this issue Sep 9, 2020
Merged
@mergify mergify bot closed this as completed in #335 Sep 14, 2020
mergify bot pushed a commit that referenced this issue Sep 14, 2020
(fix) Validate Resource before enabling an Informer against it. (#335)
87b7480 
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>

##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
 - Bug fix Pull Request

##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->

<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->

<!--- Please list dependencies added with your change also -->

Fixes #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release-blocker Upcoming release is blocked by this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(fix) Validate Resource before enabling an Informer against it. rahulchheda/botkube
1 participant
@PrasadG193