(fix) Validate Resource before enabling an Informer against it. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
|
Looks good. Can we add a unit test around it? |
added 5 commits
September 13, 2020 16:14
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
…o fixValidate Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
PrasadG193
reviewed
Sep 13, 2020
added 2 commits
September 13, 2020 22:09
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
PrasadG193
reviewed
Sep 14, 2020
| } | ||
|
|
||
| // FakeCachedDiscoveryInterface registers all the resources in the resource_config.yaml | ||
| func FakeCachedDiscoveryInterface() discovery.CachedDiscoveryInterface { |
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
PrasadG193
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rahul M Chheda rchheda@infracloud.io
ISSUE TYPE
SUMMARY
Fixes #333