Refactor Test Suits #174
Merged
Refactor Test Suits #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenio
force-pushed
the
feature/refactor-tests
branch
from
1facb0f to
a04f038
Compare
|
rebased onto develop |
Closed
PrasadG193
requested changes
Sep 3, 2019
codenio
force-pushed
the
feature/refactor-tests
branch
from
a04f038 to
90bc4bb
Compare
This Commit, - Refactors test suites to support granular integration testing - adds dedicated config file `test/config.yaml` to control integration testing of notifiers. - changes CONFIG_PATH to `pwd/test` in /hack/runtest.sh to make use of test/config.yaml - adds `go vet -tags=test ./test/...` to `./hack/verify-govet.sh`
codenio
force-pushed
the
feature/refactor-tests
branch
from
90bc4bb to
615afa3
Compare
|
resolved requested changes. It is ready now. Let's get this merged. |
PrasadG193
approved these changes
Sep 3, 2019
|
Merged! Thanks for the PR @codenio |
|
Thanks for the prompt responses @PrasadG193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This PR,
test/config.yamlto control integration testing of notifiers.pwd/testin /hack/runtest.sh to make use of test/config.yamlgo vet -tags=test ./test/...to./hack/verify-govet.sh