Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for MsTeams #170

Closed
wants to merge 1 commit into from
Closed

Add Support for MsTeams #170

wants to merge 1 commit into from

Conversation

codenio
Copy link
Contributor

@codenio codenio commented Aug 31, 2019 •
edited
Loading

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR,

  • adds support for event notifications through Microsoft Teams.
  • updates configs in all yaml files.
  • updates helm values.yaml.
  • adds unit tests for msteams notifier
  • adds integration test msteams notifier
  • adds test/msteams package to enable integration testing.

Fixes #60

Steps For Configuring MsTeams Notifier:

  • Create your MsTeams Account.
  • Configure Incomming Webhooks for your channels. (Note: follow the first 7 steps in the tutorial)
  • Place the generated Webhook Url under MsTesms section in config.yaml
  # Settings for MsTeams
    msteams:
      enabled: true
      url: 'MSTEAMS_WEBHOOK_URL'                 # e.g https://example.com:80
      notiftype: short                           # Change notification type
  • Start Botkube Server and say Tadaa..!! 🎉

Preview:

pod error: long notif

pod create : short notif

@codenio codenio force-pushed the feature/msteams-support branch 2 times, most recently from 22e7bb6 to 9929c0d Compare September 1, 2019 18:27
@codenio
Copy link
Contributor Author

codenio commented Sep 1, 2019

Rebased onto develop

@codenio
Copy link
Contributor Author

codenio commented Sep 2, 2019

waiting for #174.
will rebase/resolve conflicts altogether.

@codenio
Add Support for MsTeams
3613573 
- adds support for event notifications through Microsoft Teams.
- updates configs in all yaml files.
- updates helm values.yaml.
- adds unit tests for msteams notifier
- adds integration test msteams notifier
- adds test/msteams package to enable integration testing.
@codenio codenio force-pushed the feature/msteams-support branch from 9929c0d to 3613573 Compare September 4, 2019 06:56
@codenio
Copy link
Contributor Author

codenio commented Sep 4, 2019

Rebased onto develop, and resolved conflicts.
Let's get this reviewed and merged.

@PrasadG193
Copy link
Collaborator

As discussed following things needs to be done before we merge the PR.

@PrasadG193
Copy link
Collaborator

Addressing missing features in #242. Hence closing the PR

@PrasadG193 PrasadG193 closed this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Microsoft Teams support
2 participants
@codenio @PrasadG193