Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add glossary #529

Merged
merged 50 commits into from
Aug 24, 2023
Merged

feat: add glossary #529

merged 50 commits into from
Aug 24, 2023

Conversation

abtx
Copy link
Collaborator

@abtx abtx commented Aug 9, 2023 •
edited
Loading

All commits will be squashed when merged.

This PR:

  • adds glossary page with search
  • search state is stored in URL
  • individual page takes you to glossary/<slug>
  • content in glossaryTerms.json

@abtx abtx added the blocked label Aug 9, 2023
@abtx abtx force-pushed the feat/add-glossary branch 4 times, most recently from 126da79 to 92bf1c1 Compare August 10, 2023 13:28
@abtx abtx self-assigned this Aug 11, 2023
@abtx abtx force-pushed the feat/add-glossary branch 2 times, most recently from 5196bd9 to 6987479 Compare August 11, 2023 16:18
@abtx abtx force-pushed the feat/add-glossary branch 6 times, most recently from 2b5c38d to d56f7d8 Compare August 22, 2023 12:55
@abtx
Copy link
Collaborator Author

abtx commented Aug 22, 2023 •
edited
Loading

@hassankhosseini hey, I've added the text content to all pages now - please review. You mentioned images in the pages - thinking of adding that next. PS: here's a current link PS2: investigating why AWS isn't showing correctly - for now you can review the copy here.

@abtx abtx removed the blocked label Aug 23, 2023
@abtx abtx marked this pull request as ready for review August 23, 2023 14:34
@abtx abtx requested a review from vdmgolub August 23, 2023 14:34
@abtx abtx requested a review from aliscott August 23, 2023 16:20
vdmgolub
vdmgolub approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@vdmgolub vdmgolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍬 🚀

src/components/GlossaryPage/index.tsx Outdated Show resolved Hide resolved
src/components/GlossarySearch/GlossaryCard.css Show resolved Hide resolved
src/components/GlossaryTermPage/Cta.css Outdated Show resolved Hide resolved
src/components/GlossaryTermPage/Cta.tsx Outdated Show resolved Hide resolved
src/components/GlossarySearch/glossaryTerms.json Show resolved Hide resolved
src/components/GlossarySearch/index.tsx Show resolved Hide resolved
abtx and others added 2 commits August 24, 2023 15:15
@abtx @vdmgolub
Apply suggestions from code review
246398b 
Co-authored-by: Vadim Golub <vadim@infracost.io>
@abtx
chore: formatting
b3b2bec
@abtx abtx merged commit 28d7bc8 into master Aug 24, 2023
3 checks passed
@abtx abtx deleted the feat/add-glossary branch August 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdmgolub vdmgolub vdmgolub approved these changes

@aliscott aliscott Awaiting requested review from aliscott

Assignees

@abtx abtx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abtx @vdmgolub @hassankhosseini