Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a transaction for migrations #3009

Closed
dnephin opened this issue Aug 23, 2022 · 1 comment
Closed

Use a transaction for migrations #3009

dnephin opened this issue Aug 23, 2022 · 1 comment

Comments

@dnephin
Copy link
Contributor

dnephin commented Aug 23, 2022

Currently we don't use a transaction, but postgres supports running most operations in a transaction. We should look into adding a transaction for running migrations so that if one fails the whole thing is rolled back.
@dnephin dnephin mentioned this issue Sep 26, 2022
Merged
@dnephin
Copy link
Contributor Author

dnephin commented Oct 6, 2022

Fixed by #3157 and ##3329

@dnephin dnephin closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dnephin