Use a transaction to run data migrations #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
BruceMacD
reviewed
Sep 9, 2022
| @@ -79,6 +80,10 @@ func TestMigrations(t *testing.T) { | |||
| err := m.Migrate() | |||
| assert.NilError(t, err) | |||
|
|
|||
| t.Run("run again to check idempotency", func(t *testing.T) { | |||
dnephin
force-pushed
the
dnephin/use-txn-for-migration
branch
from
db262a2
to
7e77d1d
Compare
To check for idempotency. Also add HasFunction for checking if a function exists.
So that any failures are rolled back. We use a single transaction for all migrations because on-prem deploys will likely want to keep the old schema if any of the migrations in a new version fail.
dnephin
force-pushed
the
dnephin/use-txn-for-migration
branch
from
7e77d1d
to
a2da753
Compare
dnephin
commented
Sep 21, 2022
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also run each migration twice in the migration test to check for idempotence. Includes a couple fixes to migrations to make them idempotent.