Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a transaction to run data migrations #3157

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Use a transaction to run data migrations #3157

merged 2 commits into from
Sep 26, 2022

Commits on Sep 21, 2022

  1. improve: run the migration twice 

    To check for idempotency.

Also add HasFunction for checking if a function exists.
    @dnephin
    dnephin committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    38212e1 View commit details
    Browse the repository at this point in the history

  2. improve: run data migrations in a transaction 

    So that any failures are rolled back. We use a single transaction for
all migrations because on-prem deploys will likely want to keep the
old schema if any of the migrations in a new version fail.
    @dnephin
    dnephin committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    a2da753 View commit details
    Browse the repository at this point in the history