Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generation of openapi spec when there are no changes #1304

Merged
merged 2 commits into from
Mar 24, 2022
Merged

fix: generation of openapi spec when there are no changes #1304

merged 2 commits into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. fix: generation of openapi spec when there are no changes 

    Using reflect.Equal does not appear to work, there must be differences
between how the spec is decoded from a file, and generated from types.

This commit goes back to comparing the encoded version of the spec. That
works better, but requires that we don't append servers, otherwise the
old spec will always have different servers.

All of the other fields we set are from writeOpenAPISpec replace any
existing values, so it seems appropriate to do the same for Servers.
    @dnephin
    dnephin committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    48255be View commit details
    Browse the repository at this point in the history

  2. fix(openapi): replace date with product version 

    This allows us to remove the comparison logic and simply re-generate the spec file every time.

Co-Authored-By: Michael Yang <michael.yang@infrahq.com>
    @dnephin @mxyng
    dnephin and mxyng committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    deec706 View commit details
    Browse the repository at this point in the history