Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update connector client TLS verification #1345

Closed
wants to merge 1 commit into from
Closed

Conversation

mxyng
Copy link
Collaborator

@mxyng mxyng commented Mar 25, 2022

Summary

Update VerifyConnection function to only output the warning once. Also make it less resource hungry by creating a single CertPool that will be used instead of creating a new CertPool on each VerifyConnection call.

Misc.

Update logging to %v instead of %w

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Commit message conforms to Conventional Commit
  • GitHub Actions are passing

Related Issues

Resolves #1325

@mxyng mxyng requested a review from ssoroka March 25, 2022 22:13
@mxyng mxyng force-pushed the tls-conn-verify branch from 1780592 to f1a28ce Compare March 25, 2022 22:26
@mxyng
Copy link
Collaborator Author

mxyng commented Mar 26, 2022

Closing in favour of #1347

@mxyng mxyng closed this Mar 26, 2022
@mxyng mxyng deleted the tls-conn-verify branch April 28, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector is spewing out an x509 certificate warning every 5s
1 participant