Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prelogin page that lists orgs that were logged into, using cookies #3142

Merged
merged 9 commits into from
Sep 7, 2022
Merged

feat: prelogin page that lists orgs that were logged into, using cookies #3142

merged 9 commits into from
Sep 7, 2022

Conversation

kimskimchi
Copy link
Contributor

No description provided.

@kimskimchi kimskimchi mentioned this pull request Sep 7, 2022
Closed
@kimskimchi kimskimchi marked this pull request as ready for review September 7, 2022 14:45
jmorganca
jmorganca reviewed Sep 7, 2022
View reviewed changes
ui/pages/login/index.js
@@ -2,6 +2,7 @@ import { useRouter } from 'next/router'
import { useState } from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we also need to set the cookie at signup

@kimskimchi kimskimchi merged commit 6fe127e into main Sep 7, 2022
@kimskimchi kimskimchi deleted the kimskimchi/ui-6 branch September 7, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoyyeva hoyyeva hoyyeva approved these changes

@jmorganca jmorganca jmorganca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimskimchi @jmorganca @hoyyeva