fix: list access keys query #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set OrganizationID and order by in the query. Update the tests to catch the bug.
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
dnephin
commented
Sep 7, 2022
| @@ -291,23 +291,23 @@ func TestListAccessKeys(t *testing.T) { | |||
| createIdentities(t, db, user, otherUser) | |||
|
|
|||
| first := &models.AccessKey{ | |||
| Name: "first", | |||
| Name: "alpha", | |||
There was a problem hiding this comment.
I changed these names so that the expected values in the existing tests sort correctly. I changed the insertion order below so that the tests would fail without this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set OrganizationID and order by in the query. Update the tests to catch the bug.