Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: few more bugs on new ui #3274

Merged
merged 6 commits into from
Sep 21, 2022
Merged

fix: few more bugs on new ui #3274

merged 6 commits into from
Sep 21, 2022

Conversation

hoyyeva
Copy link
Contributor

@hoyyeva hoyyeva commented Sep 20, 2022 •
edited
Loading

Summary

  • fixed signup domain error message display
  • fixed nav sidebar ui look and feel
  • fixed autocomplete behaviour
  • fixed provider table formatting
  • removed breadcrumbs on providers add section
  • hide account on the menu when the user is not login as infra local user

Screen Shot 2022-09-20 at 11 00 41 AM

jmorganca
jmorganca requested changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments but this is overall looking good

@hoyyeva hoyyeva merged commit 77f41da into main Sep 21, 2022
@hoyyeva hoyyeva deleted the new-ui-bugs-2 branch September 21, 2022 00:10
@hoyyeva hoyyeva mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorganca jmorganca jmorganca approved these changes

@kimskimchi kimskimchi Awaiting requested review from kimskimchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoyyeva @jmorganca