fix: dont require server config base url on login #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
reviewed
Oct 3, 2022
jmorganca
reviewed
Oct 4, 2022
ui/pages/login/index.js
Outdated
| let cookieDomain = window.location.host | ||
| let parts = cookieDomain.split('.') | ||
| if (parts.length > 2) { | ||
| cookieDomain = parts.slice(-2).join('.') // join the last two parts of the domain |
There was a problem hiding this comment.
In this case, would it be better to set it to all but the first part? e.g. myorg.dev.test.com may not work here
There was a problem hiding this comment.
The "last 2 parts" here would be test.com which in my tests gets the behavior we want of sending the cookie on any domain at test.com/login/organizations.
There was a problem hiding this comment.
Fixed this to just remove the first part that is the org subdomain, this will work in dev and prod as you pointed out
BruceMacD
force-pushed
the
brucemacd/optional-login-base-domain
branch
from
8bfbf1a
to
7d0828d
Compare
hoyyeva
approved these changes
Oct 13, 2022
BruceMacD
force-pushed
the
brucemacd/optional-login-base-domain
branch
from
7b9958f
to
af1201d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When no server URL is set in server configuration set the default server URL to the current host on response. This allows the login response to continue when the optional
baseURLserver configuration is not set, but it also ensures that we wait until we have checked the server to see if there is one set.Checklist
Related Issues
Resolves #3374