fix: group trait telemetry #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
reviewed
Oct 3, 2022
| } | ||
|
|
||
| func (t *Telemetry) Event(event string, userId string, properties ...map[string]interface{}) { | ||
| func (t *Telemetry) Event(event string, userId string, orgId string, properties ...map[string]interface{}) { |
There was a problem hiding this comment.
Why not add orgID directly into properties?
There was a problem hiding this comment.
It's not an optional property and should be included in every event.
BruceMacD
reviewed
Oct 4, 2022
| UserId: userID, | ||
| Traits: map[string]interface{}{ | ||
| "name": name, | ||
| "$name": name, |
There was a problem hiding this comment.
What is the difference between name and $name here?
There was a problem hiding this comment.
One is a "super property". Some tools require both
mxyng
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.