fix: remove server lookup #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
requested review from
BruceMacD,
dnephin,
jmorganca and
pdevine
as code owners
BruceMacD
reviewed
Oct 4, 2022
dnephin
reviewed
Oct 4, 2022
mxyng
force-pushed
the
mxyng/rm-server-lookup
branch
from
8de520e
to
10fb7db
Compare
BruceMacD
approved these changes
Oct 6, 2022
dnephin
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the server lookup when server config value is
localhost. The original use case for this was to provide a simple way to configure a in-cluster connector. This is no longer useful. Users should provide the server URL explicitlyResolves #3380