fix: edit provider only update changed fields #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceMacD
approved these changes
Oct 6, 2022
mxyng
force-pushed
the
mxyng/fix-edit-providers
branch
from
5b4e793
to
44e2daa
Compare
mxyng
commented
Oct 6, 2022
hoyyeva
approved these changes
Oct 6, 2022
mxyng
force-pushed
the
mxyng/fix-edit-providers
branch
from
44e2daa
to
f5ff542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The client secret field has an initial value which gets passed to the API request even if it's unchanged. This can lead to unexpected changes to the client secret if only the name is updated.