maintain: clean up architecture...and the rest #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Williams <m@technovangelist.com>
technovangelist
requested review from
dnephin,
jmorganca,
pdevine and
mchiang0610
as code owners
mxyng
reviewed
Oct 7, 2022
docs/manage/connectors/kubernetes.md
Outdated
| @@ -42,17 +42,48 @@ helm upgrade --install infra-connector infrahq/infra \ | |||
|
|
|||
| {% callout type="info" %} | |||
|
|
|||
| Note: it may take a few minutes for the LoadBalancer to be provisioned. | |||
| Note: it may take a few minutes for the Load Balancer to be provisioned. | |||
There was a problem hiding this comment.
This shouldn't be changed since it's the Kubernetes resource name
| @@ -2,812 +2,835 @@ | |||
| title: CLI Reference | |||
There was a problem hiding this comment.
This is generated so it shouldn't be manually changed
There was a problem hiding this comment.
Oh, how is it generated? I can update that instead
There was a problem hiding this comment.
It's generated by internal/docgen. You can generate docs with go run ./internal/docgen/
mchiang0610
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
saw @mxyng's comment above per CLI docs need to be generated. Let's get that in. Otherwise this is a step forward, and we can make more iterations as we go.
Signed-off-by: Matt Williams <m@technovangelist.com>
Signed-off-by: Matt Williams <m@technovangelist.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Williams m@technovangelist.com
Summary
The architecture page had issues, so fixed them up. And then looked at active vs passive voice, better grammar throughout, and so much more.
Checklist
Related Issues
Resolves #