Enable debug log to track down test flakes in TestConnector_Run #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
BruceMacD
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestConnector_Runcan flake occasionally in CI (example), but I've never been able to reproduce it locally.From what I can tell, the connector is attempting to list destinations, but that API request never completes. The test ends up failing because the destination is not registered before the timeout.
I'm hoping it's just that CI can be very slow sometimes. The
poll.WaitOndefaults to 10 second timeout, so I've created both the context deadline and this timeout to 30 seconds.Also enable debug logging so that when it flakes maybe it gives us a bit more information about what is happening.
More links to flakes: