Remove gorm from models #3584
Merged
Remove gorm from models #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
requested review from
ssoroka,
BruceMacD,
jmorganca and
pdevine
as code owners
dnephin
commented
Nov 7, 2022
This was referenced Nov 7, 2022
The last few remaining still need to be converted to SQL. Making this change now so that it's easier to track down the remaining queries.
Also remove IsAModel which is not used.
dnephin
force-pushed
the
dnephin/remove-gorm-2
branch
from
d14099c
to
5929ddb
Compare
|
Ok, this is rebased and should be ready for review. |
7 tasks
BruceMacD
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
gormstruct tags from models, and changes the deletedAt field to use the stdlibModelablewhich is no longer used. We have interface for more specific things implemented by models likeUpdatableandorgMemberGormTxnand replaces all references to it withReadTxnorWriteTxn, and removes theGormDBmethod fromTransactionandDBnow that nothing uses it