Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go test ci #3608

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: go test ci #3608

merged 1 commit into from
Nov 10, 2022

Conversation

mxyng
Copy link
Collaborator

@mxyng mxyng commented Nov 10, 2022

Summary

GitHub's required status check need exact job name matches. In case of strategy.matrix, the job name gets modified by the matrix such that it no longer matches the configured required status check. Instead, rename the job to test-matrix and create a new job matching the required status check name dependent on text-matrix results.

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! seems like this should fix it

@mxyng mxyng force-pushed the mxyng/go-test-ci branch 2 times, most recently from 38acfe9 to aa6311a Compare November 10, 2022 18:09
@mxyng mxyng merged commit 97cf901 into main Nov 10, 2022
@mxyng mxyng deleted the mxyng/go-test-ci branch November 10, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants