Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkbox check does not show when it is checked #3624

Merged
merged 2 commits into from
Nov 14, 2022
Merged

fix: checkbox check does not show when it is checked #3624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717b57f
fix: checkbox check does not show when it is checked
Nov 11, 2022
be10a1f
fix: make sure all the checkboxs are fixed
Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/pages/destinations/[id]/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ function GrantCell({ grantsList, grant, destination, onRemove, onUpdate }) {
<input
type='checkbox'
className='h-4 w-4 rounded border-gray-300 text-blue-600 hover:cursor-pointer focus:ring-blue-500 sm:left-6'
value={resource}
checked={selectedNamespaces.includes(resource)}
onChange={e => {
setSelectedNamespaces(
Expand Down
9 changes: 5 additions & 4 deletions ui/pages/providers/add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,19 +374,20 @@ export default function ProvidersAddDetails() {
</p>
)}
</div>
<div>
<div className='group'>
<input
name='scim-checkbox'
type='checkbox'
value=''
class='h-4 w-4 rounded border-gray-300 bg-gray-100 text-blue-600 focus:ring-2 focus:ring-blue-500'
checked={enableSCIM}
class='h-4 w-4 rounded border-gray-300 bg-gray-100 text-blue-600 hover:cursor-pointer focus:ring-2 focus:ring-blue-500'
onChange={() => {
setEnableSCIM(!enableSCIM)
}}
/>
<label
htmlFor='scim-checkbox'
className='ml-2 text-sm font-medium'
className='ml-2 text-sm font-medium group-hover:cursor-pointer'
onClick={() => setEnableSCIM(!enableSCIM)}
>
Enable SCIM
</label>
Expand Down