Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cobra to official version #3648

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Update cobra to official version #3648

merged 2 commits into from
Nov 15, 2022

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Nov 15, 2022

We were using a fork for group support. That feature is now in an official release so we can stop using our fork. This will allow dependabot to notify us of updates.

Once this is merged we can archive https://github.com/infrahq/cobra

I tested this with the following

$ go build .
$ ./infra --help > before
# update cobra
$ go build .
$ ./infra help > after
$ go diff -u before after

Added a test using golden to show that it still looks the same.

Copy link
Contributor

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic thanks great catch!

Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

internal/cmd/cmd.go Outdated Show resolved Hide resolved
@dnephin
Copy link
Contributor Author

dnephin commented Nov 15, 2022

I made that change to use constants, and added a test using golden.

@dnephin dnephin merged commit dfb5df0 into main Nov 15, 2022
@dnephin dnephin deleted the dnephin/update-cobra branch November 15, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants