fix version string "vnot connected" #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
commented
Oct 14, 2021
| @@ -80,12 +80,19 @@ func checkUpdate(clientSemVer, serverSemVer string) error { | |||
| latestSemVer = strings.TrimSpace(string(body)) | |||
| } | |||
|
|
|||
| var latestVersion string | |||
|
|
|||
| _, err = fmt.Sscanf(latestSemVer, "v%s", &latestVersion) | |||
There was a problem hiding this comment.
latestVersion will only be printed if it's a valid semver which needs to start with v so shouldn't need to check if Sscanf actually scanned anything
mxyng
changed the title
mxyng
force-pushed
the
fix-version-string
branch
from
49a6d5a
to
3bedcf0
Compare
BruceMacD
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/not connected/disconnected/Fixes #459