Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish openapi #728

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Publish openapi #728

merged 3 commits into from
Dec 8, 2021

Conversation

mxyng
Copy link
Collaborator

@mxyng mxyng commented Dec 7, 2021 •
edited
Loading

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged

Resolves #426

@mxyng mxyng force-pushed the publish-openapi branch 2 times, most recently from aa2c859 to dfa50a3 Compare December 7, 2021 22:53
@mxyng mxyng added the wontfix This will not be worked on label Dec 7, 2021
BruceMacD
BruceMacD reviewed Dec 8, 2021
View reviewed changes
Makefile
openapi/go: openapi/bundled.yaml
npx @openapitools/openapi-generator-cli generate --generator-key go-client
# manually post process some files since openapi-generator forgot
openapi: openapi/clean openapi/bundled.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the separate openapi/bundled instruction now that we only have the one openapi make instruction?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still necessary because someone may want to build the bundled spec separately, for example if you want to run Swagger UI

@mxyng mxyng merged commit cdbc097 into main Dec 8, 2021
@mxyng mxyng deleted the publish-openapi branch December 8, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload OpenAPI spec to ReadMe.io on new version
2 participants
@mxyng @BruceMacD