add support for snowflake based int64 uuids #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
commented
Jan 20, 2022
| @@ -283,3 +286,5 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.1.2 // indirect | |||
| sigs.k8s.io/yaml v1.2.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/gin-gonic/gin => github.com/infrahq/gin v1.7.2-0.20220120203023-0eaa562f3a8a | |||
There was a problem hiding this comment.
this is how we can work off the fork without changing the code everywhere.
jmorganca
reviewed
Jan 20, 2022
uuid/snowflake.go
Outdated
| @@ -0,0 +1,40 @@ | |||
| package uuid | |||
jmorganca
approved these changes
Jan 21, 2022
BruceMacD
approved these changes
Jan 21, 2022
internal/api/model_user.go
Outdated
|
|
||
| // User struct for User | ||
| type User struct { | ||
| ID UUID `json:"id"` | ||
| Email string `json:"email" validate:"email,required"` | ||
| ID uuid.UUID `json:"id"` |
There was a problem hiding this comment.
Should we change this to ID in general rather than UUID? UUID implies it matches the UUID spec to me, which I don't think snowflake IDs do.
| @@ -275,7 +275,7 @@ func (a *API) ListGrants(c *gin.Context, r *api.ListGrantsRequest) ([]api.Grant, | |||
| } | |||
|
|
|||
| func (a *API) GetGrant(c *gin.Context, r *api.Resource) (*api.Grant, error) { | |||
| grant, err := access.GetGrant(c, r.ID.ToUUID()) | |||
| grant, err := access.GetGrant(c, r.ID) | |||
There was a problem hiding this comment.
these are much nicer to read now 👏
jmorganca
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ids will either have to migrate or drop/recreate.