Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused nonce from login flow #842

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Remove unused nonce from login flow #842

merged 1 commit into from
Jan 26, 2022

Conversation

BruceMacD
Copy link
Collaborator

The nonce is used to mitigate replay on attacks on implicit OAuth login flows, we don't need it on our authorization code flow.

Around the time our login flow was implemented there was a typo in the Okta docs for the authorization code flow that said it was required:
https://devforum.okta.com/t/authorization-code-flow-is-the-nonce-parameter-necessary/12150

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged

@BruceMacD BruceMacD merged commit b54ca88 into main Jan 26, 2022
@BruceMacD BruceMacD deleted the no_nonce branch January 26, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants