Add mapstructure tags to echox.Config #239
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to include the echox.Config structure in the configuration structure passed to viper.UnmarshalExact().
This also aligns the echox.Config structure to the use of mapstructure tags like all other Config structures inside config.go files like:
Note that the naming of mapstructure tags has been aligned to match the corresponding naming in the pre-existing function
MustViperFlags
.IMPORTANT: applications using the echox.Config structure should be reviewed to make sure they employ (in their configuration files) the exact syntax encoded in the mapstructure tags. For example if an application is exposing in its configuration file a parameter named 'shutdownGracePeriod', such parameter should be renamed to 'shutdown-grace-period' (this brings consistency with the viperx/cobrax bindings created by
MustViperFlags
method).