Changed the eventListener to not use EventInstances with Data since this has a major impact on memory usage. #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2024 08:23
…tead works with the event name. This is required since sending the EventInstance around including the Ingredients bloated the memory and had major performance impact. It also goes against the idea that ingredients are contained only in the process. In general ingredients are possible client data so should not be accessible in to many places.
…for the registerEventListener.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1685 +/- ##
==========================================
- Coverage 79.81% 79.65% -0.16%
==========================================
Files 143 143
Lines 4845 4842 -3
Branches 170 162 -8
==========================================
- Hits 3867 3857 -10
- Misses 978 985 +7 ☔ View full report in Codecov by Sentry. |
jwalgemoed
previously approved these changes
Jun 10, 2024
jwalgemoed
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the eventListener to not use EventInstances with Data since this has a major impact on memory usage.