Don't escape / in StackdriverApplicationLogger logs and optionally in other JSON
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionLogger The logs contain fairly regular occurrences of `/` in URLs, file paths, etc. By default PHP json_encode will encode these as `\/` but this is not required by the JSON spec. Use JSON_UNESCAPED_SLASHES to leave these as-is which will slightly reduce the size of the encoded payloads over the wire. Should not affect any JSON-compliant parser, so this is not a breaking change.
By default, we'll continue to escape them for backwards compatibility (primarily if e.g. consuming projects have got tests for the explicit encoded value). But provide an option for the caller to control this.
Still want to throw our own custom exception for BC, but might as well use the native flag to catch and rethrow JSONException rather than asserting against json_last_error_message manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the payload size on the wire for the JSON StackdriverApplicationLogger entries, by avoiding the redundant encoding of
/as\/in the output.Additionally, provide an
escaped_slashesoption toJSON::encode(defaulting true to match current behaviour) to allow for not escaping slashes in application-generated JSON.