Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about overwriting controllers when hot-reloading code #81

Closed
p-himik opened this issue Nov 15, 2019 · 2 comments
Closed

Don't warn about overwriting controllers when hot-reloading code #81

p-himik opened this issue Nov 15, 2019 · 2 comments

Comments

@p-himik
Copy link

p-himik commented Nov 15, 2019

A similar issue in re-frame: day8/re-frame#204

A workaround is pretty much the same. And I guess when that issue becomes closed, this one could be closed as well with a similar or same solution.

A side-note: while the warning tells users about overwriting a controller, in fact a merge is happening. I'm not sure if update+merge is supposed to be there instead of simple assoc.

@ingesolvoll
Copy link
Owner

A similar issue in re-frame: day8/re-frame#204

A workaround is pretty much the same. And I guess when that issue becomes closed, this one could be closed as well with a similar or same solution.

There are a few different things to consider here. There are several types of messages here that could benefit from a more fine tuned config. Starting and stopping of controllers, data diffs etc. I'm considering adding support for a map in the debug? config key, so users can pick and choose. What do you think?

A side-note: while the warning tells users about overwriting a controller, in fact a merge is happening. I'm not sure if update+merge is supposed to be there instead of simple assoc.

You are probably right that it doesn't make much sense to update+merge, don't know why I wrote it that way. Will switch to assoc and see how it works.

@p-himik
Copy link
Author

p-himik commented Dec 5, 2019

I'm considering adding support for a map in the debug? config key, so users can pick and choose. What do you think?

It's hard to say no for more logging. :)
Although I wouldn't use :debug? for this since its name clearly conveys that it should be a boolean. Maybe :debug-config or something like that that's ignored if :debug? is false-y.

ingesolvoll pushed a commit that referenced this issue Dec 5, 2019
ingesolvoll pushed a commit that referenced this issue Dec 5, 2019
ingesolvoll pushed a commit that referenced this issue Dec 5, 2019
ingesolvoll pushed a commit that referenced this issue Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants