Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct typo in method name 'sirenLinkDisocoverer()' in class 'SirenMediaTypeConfiguration' #247

Closed
toedter opened this issue Apr 15, 2021 · 3 comments
Closed

Correct typo in method name 'sirenLinkDisocoverer()' in class 'SirenMediaTypeConfiguration' #247

toedter opened this issue Apr 15, 2021 · 3 comments
Assignees
@ingogriebsch
Labels
type:bug Something isn't working
Milestone
1.1.0

Comments

@toedter
Copy link

toedter commented Apr 15, 2021

In class SirenMediaTypeConfiguration, line 109:

LinkDiscoverer sirenLinkDisocoverer() {
                           ^

should be renamed to:

LinkDiscoverer sirenLinkDiscoverer() {
@toedter toedter added the type:bug Something isn't working label Apr 15, 2021
@ingogriebsch
Copy link
Owner

Thanks for the hint, @toedter ! :)

@ingogriebsch ingogriebsch added this to the 1.1.0 milestone Apr 15, 2021
@toedter
Copy link
Author

toedter commented Apr 15, 2021 •
edited
Loading

Funny thing, I started to implement a JsonApiLinkDiscoverer and was interested in your implementation. And so I stumbled about it :)

@ingogriebsch ingogriebsch changed the title Typo: sirenLinkDisocoverer() Correct typo in method name 'sirenLinkDisocoverer()' in class 'SirenMediaTypeConfiguration' Apr 17, 2021
ingogriebsch added a commit that referenced this issue Apr 17, 2021
@ingogriebsch
fix(#247): Correct typo in method name 'sirenLinkDisocoverer()'
5999ba4
@ingogriebsch
Copy link
Owner

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ingogriebsch ingogriebsch

Labels
type:bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@toedter @ingogriebsch