pr comments

ingonyama-zk · Nov 22, 2024 · 30462c6 · 30462c6
1 parent 91ae2b3
commit 30462c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/wrappers/rust/icicle-core/src/ntt/mod.rs b/wrappers/rust/icicle-core/src/ntt/mod.rs
@@ -44,7 +44,7 @@ pub enum NTTDir {
 /// - kMN: inputs are digit-reversed-order (=mixed) and outputs are natural-order.
 #[allow(non_camel_case_types)]
 #[repr(C)]
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd)]
 pub enum Ordering {
     kNN,
     kNR,
@@ -451,8 +451,8 @@ macro_rules! impl_ntt_bench {
             let min_log2 = get_env_log2("MIN_LOG2", min_log2_default);
             let max_log2 = get_env_log2("MAX_LOG2", max_log2_default);
 
-            assert!(min_log2 >= min_log2_default);
-            assert!(min_log2 < max_log2);
+            assert!(min_log2 >= min_log2_default, "MIN_LOG2 must be >= {}", min_log2_default);
+            assert!(min_log2 < max_log2, "MAX_LOG2 must be > MIN_LOG2");
 
             (min_log2, max_log2)
         }

diff --git a/wrappers/rust/icicle-core/src/ntt/tests.rs b/wrappers/rust/icicle-core/src/ntt/tests.rs
@@ -331,7 +331,8 @@ where
                         config.ordering = ordering;
                         let mut batch_ntt_result = vec![F::zero(); batch_size * test_size];
                         for alg in [NttAlgorithm::Radix2, NttAlgorithm::MixedRadix] {
-                            if alg == NttAlgorithm::Radix2 && ordering as u32 > 3 {
+                            if alg == NttAlgorithm::Radix2 && (ordering > Ordering::kRR) {
+                                // Radix2 does not support kNM and kMN ordering
                                 continue;
                             }
                             config.batch_size = batch_size as i32;