Feat/vlad/poseidon go binding #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonHibnik
approved these changes
May 12, 2024
wrappers/golang/internal/generator/poseidon/templates/poseidon_test.go.tmpl
Show resolved
Hide resolved
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
…zk/icicle into feat/vlad/poseidon-go-binding
ChickenLover
approved these changes
May 17, 2024
yshekel
pushed a commit
that referenced
this pull request
May 19, 2024
yshekel
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds a golang binding for poseidon.
Also it adds a test to verify that it runs for every curve and, for bls12-381 specifically, it checks correctness against a precomputed value.
The reason I didn't test every curve (or the different arities/number of states) is I couldn't find a library that supports everything we do to compare against.
I'll add tests for bn254 and bls12-371 later.
Linked Issues
Resolves #