Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yshekel/poly view fix #514

Merged
merged 9 commits into from
May 15, 2024
Merged

Yshekel/poly view fix #514

merged 9 commits into from
May 15, 2024

Conversation

yshekel
Copy link
Collaborator

@yshekel yshekel commented May 12, 2024 •
edited
Loading

This PR :

  • removes the poly API to access view of evaluations. This is a problematic API since it cannot handle small domains and for large domains requires the polynomial to use more memory than need to.
  • adds evaluate_on_rou_domain() API instead that supports any domain size (powers of two size).
  • the new API can compute to HOST or DEVICE memory
  • Rust wrapper for evaluate_on_rou_domain()
  • updated documentation: overview and Rust wrappers
  • faster division by vanishing poly for common case where numerator is 2N and vanishing poly is of degree N.
  • allow division a/b where deg(a)<deg(b) instead of throwing an error.

@yshekel yshekel merged commit 9c1afe8 into main May 15, 2024
26 checks passed
@yshekel yshekel deleted the yshekel/poly_view_fix branch May 15, 2024 11:06
yshekel added a commit that referenced this pull request May 19, 2024
@yshekel
Polynomial API views replaced by evaluation on rou domain (#514)
6d3938e 
- removed poly API to access view of evaluations. This is a problematic API since it cannot handle small domains and for large domains requires the polynomial to use more memory than need to.
- added evaluate_on_rou_domain() API instead that supports any domain size (powers of two size).
- the new API can compute to HOST or DEVICE memory
- Rust wrapper for evaluate_on_rou_domain()
- updated documentation: overview and Rust wrappers
- faster division by vanishing poly for common case where numerator is 2N and vanishing poly is of degree N.
- allow division a/b where deg(a)<deg(b) instead of throwing an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenLover ChickenLover ChickenLover approved these changes

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@svpolonsky svpolonsky Awaiting requested review from svpolonsky

@jeremyfelder jeremyfelder Awaiting requested review from jeremyfelder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshekel @ChickenLover @LeonHibnik