Feat/roman/dcct #572
Open
Feat/roman/dcct #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChickenLover
force-pushed
the
feat/roman/dcct
branch
from
ee59011
to
38bcbfb
Compare
yshekel
reviewed
Oct 1, 2024
yshekel
reviewed
Oct 1, 2024
|
|
||
| const c_extension_t ROU = {{2}, {1268011823}}; | ||
|
|
||
| // namespace quad_extension_config { |
yshekel
reviewed
Oct 1, 2024
| @@ -6,7 +6,10 @@ | |||
| #include "ntt/ntt.cuh" // for enum Ordering | |||
|
|
|||
| namespace mxntt { | |||
|
|
|||
| #ifdef DCCT | |||
| template <typename S, typename R> | |||
There was a problem hiding this comment.
is R an extension field? why R?
There was a problem hiding this comment.
It means Root type
yshekel
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Overall looks good to me but I have a few comments:
(1) I don't see that you define DCCT in cmake (and cargo) for m31 and build dcct
(2) Probably NTT tests will fail so we need some correctness test in CI.
(3) It would be better in terms of maintainability if you split dcct code from ntt sources. Assuming it doesn't required you to refactor too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR...
Linked Issues
Resolves #