update msm wrappers #587
Merged
update msm wrappers #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Aug 26, 2024
yshekel
reviewed
Aug 26, 2024
| for batch_size in batch_sizes { | ||
| let scalars = <C::ScalarField as FieldImpl>::Config::generate_random(test_size * batch_size); | ||
| // a version of batched msm without using `cfg.points_size`, requires copying bases | ||
| // let points_cloned: Vec<Affine<C>> = std::iter::repeat(points.clone()) |
There was a problem hiding this comment.
This was a confusion in previous versions. Safe to remove @nonam3e
|
looks good, let's merge CPU MSM and then merge this too without the TODOs |
ChickenLover
approved these changes
Aug 27, 2024
nonam3e
force-pushed
the
nonam3e/rust_wrappers/msm_precompute
branch
from
7fd96b7 to
3e53a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds not shared bases option in rust bindings