Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Program-support #664

Merged
merged 14 commits into from
Nov 26, 2024
Merged

Program-support #664

merged 14 commits into from
Nov 26, 2024

Conversation

mickeyasa
Copy link
Contributor

Describe the changes

This PR...

Linked Issues

Resolves #

danny-shterman
danny-shterman approved these changes Nov 24, 2024
View reviewed changes
icicle/include/icicle/program/program.h Outdated Show resolved Hide resolved
icicle/backend/cpu/include/cpu_program_executor.h Outdated Show resolved Hide resolved
yshekel
yshekel requested changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff but I have some comments, mainly around naming and the design of the program class etc. I think it should be structured more like modern compilers and not violate the single-responsibility principle by having the program class do everything from the initial IR to compiled code.

@mickeyasa mickeyasa requested a review from yshekel November 25, 2024 13:14
@mickeyasa mickeyasa merged commit 7a36c46 into main Nov 26, 2024
29 checks passed
@mickeyasa mickeyasa deleted the Program-support branch November 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHibnik LeonHibnik LeonHibnik left review comments

@danny-shterman danny-shterman danny-shterman approved these changes

@yshekel yshekel yshekel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickeyasa @yshekel @danny-shterman @LeonHibnik