Replace rand() with rand_uint_32b() for reproducibility #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koren-Brand <koren@ingonyama.com>
yshekel
changed the title
yshekel
reviewed
Dec 4, 2024
yshekel
reviewed
Dec 4, 2024
yshekel
reviewed
Dec 4, 2024
yshekel
reviewed
Dec 4, 2024
yshekel
reviewed
Dec 4, 2024
mickeyasa
reviewed
Dec 5, 2024
…test_hash_api's randomise function to use rand_uint_32b instead of just rand_generator Signed-off-by: Koren-Brand <koren@ingonyama.com>
Signed-off-by: Koren-Brand <koren@ingonyama.com>
Koren-Brand
changed the title
…hat size_out is non-negative Signed-off-by: Koren-Brand <koren@ingonyama.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the previous rand PR - replacing every place rand() is called with a new rand_int function based on the same rand_generator in rand_gen.h - making test runs deterministic when given a fixed seed (Aiding debugging).