Blake3 CPU support #733
Merged
Blake3 CPU support #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeyasa
reviewed
Jan 12, 2025
docs/docs/icicle/primitives/hash.md
Outdated
| @@ -40,6 +41,10 @@ Keccak can take input messages of any length and produce a fixed-size hash. It u | |||
|
|
|||
| [Blake2s](https://www.rfc-editor.org/rfc/rfc7693.txt) is an optimized cryptographic hash function that provides high performance while ensuring strong security. Blake2s is ideal for hashing small data (such as field elements), especially when speed is crucial. It produces a 256-bit (32-byte) output and is often used in cryptographic protocols. | |||
|
|
|||
| ### Blake3 | |||
|
|
|||
| [Blake3](https://www.ietf.org/archive/id/draft-aumasson-blake3-00.html) is a high-performance cryptographic hash function designed for both small and large data. With variable-length output (default 256 bits) and a tree-based design for efficient parallelism, it offers strong security, speed, and scalability for modern cryptographic applications. | |||
There was a problem hiding this comment.
do we support the variable input size?
There was a problem hiding this comment.
assuming you mean output as stated in the phrase, we technically support variable output-size but it is not tested and not really common. I'll remove this line.
There was a problem hiding this comment.
I asked about any input size.
Do we support any size of input?
mickeyasa
reviewed
Jan 12, 2025
mickeyasa
reviewed
Jan 12, 2025
mickeyasa
reviewed
Jan 12, 2025
mickeyasa
reviewed
Jan 12, 2025
mickeyasa
reviewed
Jan 12, 2025
mickeyasa
reviewed
Jan 12, 2025
mickeyasa
reviewed
Jan 12, 2025
LeonHibnik
reviewed
Jan 12, 2025
LeonHibnik
approved these changes
Jan 13, 2025
yshekel
reviewed
Jan 14, 2025
| @@ -371,7 +371,7 @@ class VectorOpTask : public TaskBase | |||
| public: | |||
| T m_intermidiate_res; // pointer to the output. Can be a vector or scalar pointer | |||
| uint64_t m_idx_in_batch; // index in the batch. Used in intermediate res tasks | |||
| }; | |||
| }; // class VectorOpTask | |||
There was a problem hiding this comment.
this comment is causing issues for formatters (they format it differently for some reason) so I suggest removing it
yshekel
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding Blake3 support in C, RUST and GO.
Including unit tests in all 3 frontends
cuda-backend-branch: aviad/blake3_cuda